Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update a few URLs in example documentation #3882

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

veleek
Copy link
Contributor

@veleek veleek commented Apr 2, 2021

Updated a few URLs to point to current locations (as opposed to redirect URLs).
In the Service Account URLs case, it was pointing to a non-existant cloud console page.

@veleek veleek requested a review from a team as a code owner April 2, 2021 00:55
@google-cla
Copy link

google-cla bot commented Apr 2, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 2, 2021
@veleek veleek changed the title Update a few URLs in example documentation fix: update a few URLs in example documentation Apr 2, 2021
@veleek
Copy link
Contributor Author

veleek commented Apr 2, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 2, 2021
Updated a few URLs to point to current locations (as opposed to redirect
URLs). In the Service Account URLs case, it was pointing to a
non-existant cloud console page.
@codyoss codyoss changed the title fix: update a few URLs in example documentation docs: update a few URLs in example documentation Apr 2, 2021
@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2021
@codyoss
Copy link
Member

codyoss commented Apr 2, 2021

@veleek Thanks for the updated URLs, looks good to me.

@codyoss codyoss added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Apr 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 17cae3c into googleapis:master Apr 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants