Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dialogflow/cx): start generating apiv3 #3850

Merged
merged 3 commits into from
Mar 23, 2021
Merged

feat(dialogflow/cx): start generating apiv3 #3850

merged 3 commits into from
Mar 23, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Mar 23, 2021

Fixes: #3634

@codyoss codyoss requested a review from tbpg March 23, 2021 15:52
@codyoss codyoss requested a review from a team as a code owner March 23, 2021 15:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2021
@product-auto-label product-auto-label bot added the api: dialogflow Issues related to the Dialogflow API. label Mar 23, 2021
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Kokoro is failing, but it seems unrelated?

@codyoss
Copy link
Member Author

codyoss commented Mar 23, 2021

@tbpg Should be fixed now, I must have had a dirty workspace from some other testing I was doing.

@codyoss codyoss requested a review from tbpg March 23, 2021 16:46
@@ -570,6 +570,15 @@ var microgenGapicConfigs = []*microgenConfig{
apiServiceConfigPath: "google/cloud/dialogflow/cx/v3beta1/dialogflow_v3beta1.yaml",
releaseLevel: "beta",
},
{
inputDirectoryPath: "google/cloud/dialogflow/cx/v3",
pkg: "cx",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a not-great package name. But, too late for that. :)

@codyoss codyoss merged commit febbdcf into googleapis:master Mar 23, 2021
@codyoss codyoss deleted the cx-v3 branch September 11, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dialogflow Issues related to the Dialogflow API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dialogflow: support apiv3
2 participants