Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal/apidiff): check for bang breaking change indicator #3840

Merged
merged 3 commits into from
Mar 19, 2021

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Mar 19, 2021

Allow breaking changes when either of the conventional commit breaking change indicators are available: ! or BREAKING CHANGE:.

An example of the former is: fix!(dialogflow): remove rpc or fields that are unintended to release

@noahdietz noahdietz requested a review from a team as a code owner March 19, 2021 18:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahdietz noahdietz merged commit a58a0e6 into googleapis:master Mar 19, 2021
@noahdietz noahdietz deleted the apidiff-allow-bang branch March 19, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants