Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor genlocal into genbot #3674

Merged
merged 3 commits into from Feb 5, 2021
Merged

chore: refactor genlocal into genbot #3674

merged 3 commits into from Feb 5, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Feb 4, 2021

Previously if you wanted to run genlocal you needed to have a
bunch of dependencies installed. Some of which can be a little
tricky to install correctly. These dependencies happen to be the
same as genbot. For this reason this commit refactors genlocal
into genbot so that the genbot in local mode can be run from
a docker container that has the exact same deps installed as our
nightly regen.

Previously if you wanted to run genlocal you needed to have a
bunch of dependencies installed. Some of which can be a little
tricky to install correctly. These dependencies happen to be the
same as genbot. For this reason this commit refactors genlocal
into genbot so that the genbot in local mode can be run from
a docker container that has the exact same deps installed as our
nightly regen.
@codyoss codyoss requested a review from a team as a code owner February 4, 2021 21:17
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2021
@codyoss codyoss requested a review from tbpg February 4, 2021 21:17
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't do a super thorough review -- LGTM overall.

internal/gapicgen/cmd/genbot/README.md Outdated Show resolved Hide resolved
codyoss and others added 2 commits February 5, 2021 08:47
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants