Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(firestore): added != and not-in to godoc #3673

Merged
merged 4 commits into from
Feb 5, 2021
Merged

docs(firestore): added != and not-in to godoc #3673

merged 4 commits into from
Feb 5, 2021

Conversation

54m
Copy link
Contributor

@54m 54m commented Feb 4, 2021

fix godoc for firestore v1.4.0 (!= & not-in)

@54m 54m requested review from crwilcox, tritone and a team as code owners February 4, 2021 14:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2021
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Feb 4, 2021
@codyoss codyoss changed the title update(firestore): added != and not-in to godoc docs(firestore): added != and not-in to godoc Feb 4, 2021
@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2021
codyoss
codyoss reviewed Feb 4, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but will let @crwilcox have the final say.

@54m
Copy link
Contributor Author

54m commented Feb 4, 2021

@codyoss
change the commit message?

@codyoss
Copy link
Member

codyoss commented Feb 4, 2021

@54m You can if you like, or we can update it when to squash and merge. Up to you 😄 Thanks for the contribution!

@54m
Copy link
Contributor Author

54m commented Feb 4, 2021

@codyoss OK! Just a moment, please.

@54m
Copy link
Contributor Author

54m commented Feb 4, 2021

@codyoss done.

crwilcox
crwilcox previously approved these changes Feb 4, 2021
View reviewed changes
@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Feb 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2021
@gcf-merge-on-green gcf-merge-on-green bot dismissed crwilcox’s stale review February 4, 2021 19:58

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Feb 5, 2021
@54m
Copy link
Contributor Author

54m commented Feb 5, 2021

@codyoss What happened?

@tritone
Copy link
Contributor

tritone commented Feb 5, 2021

Looks like we didn't have an approving review. Also, merge on green sometimes doesn't work on community contributions since the CI doesn't run automatically. I will try to merge now.

@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2021
@54m
Copy link
Contributor Author

54m commented Feb 5, 2021

@tritone Thank you for running the CI.

@tritone tritone merged commit 7a56edf into googleapis:master Feb 5, 2021
@54m 54m deleted the fix-godoc-for-v1.4.0 branch February 5, 2021 18:32
This was referenced Mar 8, 2021
Closed
Closed
Closed
Merged
Closed
Closed
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss left review comments

@tritone tritone tritone approved these changes

@crwilcox crwilcox crwilcox left review comments

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@54m @codyoss @tritone @crwilcox @kokoro-team