Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigtable): delete table retry fix #3443

Conversation

AlisskaPie
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2020
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Dec 10, 2020
@chelleyyy
Copy link

Nicht erlaubter Zugriff

@AlisskaPie
Copy link
Contributor Author

While working on BackupIAM and TableIam tests, I've noticed that the table was actually deleted with deleteTable function but I had Not Found log error:
image

I've made an update using the logic in retry function:

It returns when one of the following occurs:
// When f's first return value is true, Retry immediately returns with f's second
// return value.
// When the provided context is done, Retry returns with an error that
// includes both ctx.Error() and the last error returned by f.

@AlisskaPie AlisskaPie marked this pull request as ready for review December 10, 2020 09:10
@AlisskaPie AlisskaPie requested review from tritone and a team as code owners December 10, 2020 09:10
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this seems correct now.

@tritone tritone changed the title fix(bigtable): delete table retry fix test(bigtable): delete table retry fix Jan 14, 2021
@tritone tritone requested a review from kolea2 January 14, 2021 18:45
@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants