New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): support NUMERIC in mutations #3328
feat(spanner): support NUMERIC in mutations #3328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks for fixing this.
It would have been good to have a test case that would note this in case there are new data types added in the future, but apparently that is missing. We can add that through a separate PR.
@tbpg Do you have any idea why the kokoro run seems to be hanging indefinitely? I've tried to trigger the execution a number of times, but it never seems to finish (or report a status). |
@olavloite, sorry, just saw this. I added the label to start Kokoro. Must have missed the initial webhook or something. |
No problem, thanks for looking into it :-) |
This PR adds support of NUMERIC type in mutations.
ref #3327