feat(spanner/spannertest): support AVG aggregation function #3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
dsymonds
reviewed
Dec 1, 2020
spanner/spansql/keywords.go
Outdated
| @@ -135,6 +135,7 @@ var funcs = map[string]bool{ | |||
| "MAX": true, | |||
| "MIN": true, | |||
| "SUM": true, | |||
| "AVG": true, | |||
There was a problem hiding this comment.
keep these in alphabetical order.
There was a problem hiding this comment.
I didn't notice the order rule, thanks.
6445399
spanner/spansql/parser_test.go
Outdated
| @@ -111,6 +111,20 @@ func TestParseQuery(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| {`SELECT AVG(PointsScored) AS total_points, FirstName, LastName AS surname FROM PlayerStats GROUP BY FirstName, LastName`, | |||
There was a problem hiding this comment.
this test case is really not needed.
There was a problem hiding this comment.
OK, removed.
8b733f1
|
@dsymonds Thanks for your review. I updated the points you commented. Can you check them again? |
…ogle-cloud-go into add_avg_support_to_spannertest
dsymonds
added
automerge
gcf-merge-on-green
bot
dismissed
dsymonds’s stale review
This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.
dsymonds
added
automerge
dsymonds
approved these changes
Dec 2, 2020
kokoro-team
removed
the
kokoro:run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3285
Sorry for creating PR without waiting for the response to the above issue 😅