Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add api-logging codeowners #3093

Merged
merged 20 commits into from Oct 29, 2020
Merged

chore: add api-logging codeowners #3093

merged 20 commits into from Oct 29, 2020

Conversation

simonz130
Copy link

@simonz130 simonz130 commented Oct 27, 2020 •
edited

  • Debranded logging and error reporting from "Stackdriver"
  • Added api-logging team to codeowners of logging and error reporting

@simonz130 simonz130 added api: logging Issues related to the Cloud Logging API. api: clouderrorreporting Issues related to the Error Reporting API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like. automerge Merge the pull request once unit tests and other checks pass. labels Oct 27, 2020
@simonz130 simonz130 requested a review from a team as a code owner October 27, 2020 06:48
@simonz130 simonz130 self-assigned this Oct 27, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 27, 2020
codyoss
codyoss reviewed Oct 27, 2020
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple nits

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@simonz130 simonz130 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 29, 2020
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 29, 2020
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Oct 29, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 07004ba into master Oct 29, 2020
@gcf-merge-on-green gcf-merge-on-green bot deleted the api-logging-codeowners branch October 29, 2020 14:16
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

@0xSage 0xSage Awaiting requested review from 0xSage

Assignees

@simonz130 simonz130

Labels
api: clouderrorreporting Issues related to the Error Reporting API. api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@simonz130 @codyoss @tbpg @0xSage