You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain scenarios (usually on network disconnect but to be fully determined), an unknown context deadline exceeded error from ModifyAckDeadline can shutdown the iterator and cause it to fail. This is usually captured by the case prior to default in the switch statement, but sometimes the error is not captured properly. This PR patches the issue so users are not negatively affected.
Upon further investigation, the error seems to be originating from the gax.Sleep call. The context is cancelled, and a fallthrough happens. However, since the err is not checked directly (rather the previously stored error code which is a Unavailable), the context deadline exceeded error is bubbled up to the client library user. Will be updating this PR to address.
edit: This is wrong. The gax.Sleep deadline is properly falling through to the next call, which means this can't be the source of context deadline exceeded errors. However, some context deadline exceeded errors are not captured by the switch case (https://play.golang.org/p/rgJjhB-BLl-).
api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
google-cla
bot
added
the
cla: yes
In certain scenarios (usually on network disconnect but to be fully determined), an unknown
context deadline exceedederror fromModifyAckDeadlinecan shutdown the iterator and cause it to fail. This is usually captured by the case prior todefaultin the switch statement, but sometimes the error is not captured properly. This PR patches the issue so users are not negatively affected.