Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner/spansql): parse CHECK constraints #3046

Merged
merged 1 commit into from
Oct 19, 2020
Merged

feat(spanner/spansql): parse CHECK constraints #3046

merged 1 commit into from
Oct 19, 2020

Conversation

dsymonds
Copy link
Contributor

This results in a minor backward-incompatible change to TableConstraint
to support both Check and ForeignKey appearing as constraints.

@dsymonds dsymonds added the api: spanner Issues related to the Spanner API. label Oct 19, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2020
skuruppu
skuruppu approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@skuruppu skuruppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to mark this as a breaking change, I think we have a release coming up where we may have to do a major version bump (late Nov -- mid Dec) so we can hold off merging this in until then.

@dsymonds
feat(spanner/spansql): parse CHECK constraints
0c3a492 
This results in a minor backward-incompatible change to TableConstraint
to support both Check and ForeignKey appearing as constraints.
@dsymonds
Copy link
Contributor Author

Thanks, but I think it's fine. We haven't aimed to maintain any sort of strict compatibility for spansql or spannertest, and the only folk broken should be people using constraints.

@dsymonds dsymonds added the automerge Merge the pull request once unit tests and other checks pass. label Oct 19, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit c7f019e into googleapis:master Oct 19, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 19, 2020
@dsymonds dsymonds deleted the spansql-check branch October 19, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuruppu skuruppu skuruppu approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsymonds @skuruppu