feat(spanner/spannertest): implement RIGHT JOIN #3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restructure and make a unified JOIN implementation. FULL JOIN is still not supported, but all other variations of joins now work.
google-cla
bot
added
the
cla: yes
dsymonds
commented
Oct 17, 2020
| return true, nil | ||
| } | ||
| ji.zero = func(primary row) { | ||
| populate(primary, nil) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| type joinIter struct { |
There was a problem hiding this comment.
I suggest starting to review from the changes to the joinIter struct; the rest should hopefully flow directly from that.
olavloite
approved these changes
Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure and make a unified JOIN implementation.
FULL JOIN is still not supported, but all other variations of joins now
work.