Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add missing StorageClass in BucketAttrsToUpdate #3038

Merged
merged 6 commits into from Dec 3, 2020

Conversation

AlisskaPie
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 16, 2020
@AlisskaPie AlisskaPie marked this pull request as ready for review October 16, 2020 13:23
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 17, 2020
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Will merge when you stamp @frankyn

@AlisskaPie
Copy link
Contributor Author

Gentle ping

@tbpg
Copy link
Contributor

tbpg commented Dec 1, 2020

@tritone @frankyn, are we good to merge this?

@frankyn
Copy link
Member

frankyn commented Dec 2, 2020

Apologies for the lag here, totally missed this.

@tritone tritone requested a review from a team as a code owner December 2, 2020 18:02
@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants