Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner/spannertest): correct handling of NULL AND FALSE #2991

Merged
merged 1 commit into from
Oct 9, 2020
Merged

fix(spanner/spannertest): correct handling of NULL AND FALSE #2991

merged 1 commit into from
Oct 9, 2020

Conversation

dsymonds
Copy link
Contributor

@dsymonds dsymonds commented Oct 9, 2020

92bfe7f got most things correct, but I relied on the docs, which have an
error and so one case was incorrect.

(Internally filed as b/170436130)

@dsymonds dsymonds added release blocking Required feature/issue must be fixed prior to next release. api: spanner Issues related to the Spanner API. labels Oct 9, 2020
@dsymonds dsymonds requested a review from skuruppu October 9, 2020 02:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 9, 2020
olavloite
olavloite approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting. I think there's as small copy-paste error in one comment, otherwise LGTM.

spanner/spannertest/db_eval.go Outdated Show resolved Hide resolved
@dsymonds
fix(spanner/spannertest): correct handling of NULL AND FALSE
4694cbb 
92bfe7f got most things correct, but I relied on the docs, which have an
error and so one case was incorrect.
@dsymonds dsymonds added the automerge Merge the pull request once unit tests and other checks pass. label Oct 9, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit df54b97 into googleapis:master Oct 9, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 9, 2020
@dsymonds dsymonds deleted the spannertest-and-null branch October 9, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. release blocking Required feature/issue must be fixed prior to next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsymonds @olavloite