fix(bigquery): address fastpath iteration with iterator.Pager #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iterating query results from the fastpath with an iterator.Pager forces a cache miss if the pager size is misaligned with the cached page size. Logic to reduce the size of the getQueryResults payload by dictating the projected fields was yielding an empty pageToken and no rows, which is equivalent to an empty page response. This PR corrects the projection logic, and adds an integration test to exercise the use of misaligned paging.
google-cla
bot
added
the
cla: yes
hongalex
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterating query results from the fastpath with an iterator.Pager
forces a cache miss if the pager size is misaligned with the cached
page size.
Logic to reduce the size of the getQueryResults payload by dictating
the projected fields was yielding an empty pageToken and no rows, which
is equivalent to an empty page response.
This PR corrects the projection logic, and adds an integration test to
exercise the use of misaligned paging.
Fixes: #2946