feat(pubsub/pstest)!: Add status code to error injection. #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
zhongduo
force-pushed
the
error-injection-code
branch
from
0517d2e
to
25a8531
Compare
|
/assign @hongalex |
A status code is added into errorInjectionReactor, this is necessary as the retry setting for some calls depends on the error code. Also the errorInjectionReactor is not exported. Note that the previous version is same as having an Unknown code as the server will always wrap the error to a proper status error.
zhongduo
force-pushed
the
error-injection-code
branch
from
25a8531
to
a2f8d9c
Compare
hongalex
changed the title
hongalex
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
hongalex
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A status code is added into errorInjectionReactor, this is necessary
as the retry setting for some calls depends on the error code. Also
the errorInjectionReactor is not exported. Note that the previous
version is same as having an Unknown code as the server will always
wrap the error to a proper status error.
BREAKING CHANGE: this will invalidate the previous exported
ErrorInjectionReactorstruct andWithErrorInjectionfunction.