feat(pubsub/pstest): Add reactor options to pstest server #2916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
/assign @hongalex |
hongalex
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
codyoss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
zhongduo
changed the title
hongalex
changed the title
hongalex
approved these changes
Sep 25, 2020
hongalex
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
hongalex
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
zhongduo
force-pushed
the
pstest-reactor-option
branch
4 times, most recently
from
7c5fd6c
to
57044b2
Compare
This allows users to define customized reactor to a sub command handler. An example is to inject error in topic deletion. A generic ErrorInjection is also provided to inject error to handlers.
zhongduo
force-pushed
the
pstest-reactor-option
branch
from
57044b2
to
20f4edd
Compare
hongalex
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reactor options to pstest server.
This allows users to define customized reactor to a sub command handler. An example is to inject error in topic deletion.
Note: only the DeleteTopic is shown as an example here, after we settle down the naming and formatting, similar reactor will be added to all the functions.