Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spanner/spansql): use ID type for identifiers throughout #2889

Merged
merged 1 commit into from
Sep 18, 2020
Merged

chore(spanner/spansql): use ID type for identifiers throughout #2889

merged 1 commit into from
Sep 18, 2020

Conversation

dsymonds
Copy link
Contributor

This was a long-planned cleanup, which adds some rigour to the type
definitions, and avoids a bunch of unnecessary casting in various
places.

@dsymonds dsymonds added the api: spanner Issues related to the Spanner API. label Sep 18, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2020
@olavloite olavloite changed the title spanner/spansql: use ID type for identifiers throughout chore(spanner/spansql): use ID type for identifiers throughout Sep 18, 2020
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spanner/spannertest/inmem.go Outdated Show resolved Hide resolved
This was a long-planned cleanup, which adds some rigour to the type
definitions, and avoids a bunch of unnecessary casting in various
places.
@dsymonds dsymonds added the automerge Merge the pull request once unit tests and other checks pass. label Sep 18, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 80f55c7 into googleapis:master Sep 18, 2020
@dsymonds dsymonds deleted the spansql-id branch September 18, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants