spanner/spannertest: fix aggregation in query evaluation for empty in… #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…puts The aggregation was applying grouping to the entire table if no grouping was found, but that should only apply if there isn't a GROUP BY clause, not if a GROUP BY clause found no rows (e.g. for an empty table). Fixes #2793
google-cla
bot
added
the
cla: yes
skuruppu
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…puts
The aggregation was applying grouping to the entire table if no grouping
was found, but that should only apply if there isn't a GROUP BY clause,
not if a GROUP BY clause found no rows (e.g. for an empty table).
Fixes #2793