Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add custom type support to spanner.Key #2748

Merged
merged 3 commits into from Aug 20, 2020

Conversation

vvakame
Copy link
Contributor

@vvakame vvakame commented Aug 19, 2020

fixes #2747

@vvakame vvakame requested a review from skuruppu as a code owner August 19, 2020 02:16
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2020
@hengfengli hengfengli changed the title feat(spanner): add custome type support to spanner.Key feat(spanner): add custom type support to spanner.Key Aug 20, 2020
Copy link
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. LGTM. 👍

@hengfengli hengfengli added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 20, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 20, 2020
@skuruppu skuruppu added the automerge Merge the pull request once unit tests and other checks pass. label Aug 20, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@skuruppu skuruppu added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 20, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 20, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit f799758 into googleapis:master Aug 20, 2020
@vvakame vvakame deleted the spanner-custom-key branch August 20, 2020 11:14
tritone pushed a commit to tritone/google-cloud-go that referenced this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spanner: support custom key type encode/decode
4 participants