feat(spanner/spannertest): add support for bool parameter types #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
dsymonds
reviewed
Aug 5, 2020
|
Thanks, this is just an oversight (or having not gotten to it, as a nearby TODO indicates). The fix looks good, but please drop the integration_test.go change. |
codyoss
changed the title
dsymonds
approved these changes
Aug 13, 2020
|
Cool, should be all set. |
|
Hey @sporkmonger, I think you need to rebase your branch or merge master into it so we can merge this into master. |
|
Done. |
|
Hey @skuruppu, do you know why kokoro isn't reporting back? It's blocking being able to submit this change. |
dsymonds
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
dsymonds
added
the
automerge
|
Yeah, somehow the notification never makes it to GitHub even though the test has run on Kokoro. I usually fiddle with TestFusion to get it working again but I think you need permissions for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this against my own codebase as well and it resolved the issue for both my code as well as the integration tests. Previously this would fail with: