docs: update CONTRIBUTING.md with some PR setup info #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an explicit mention to enable "Allow edits by maintainers" when setting up the pull request. In PR googleapis#2574 (external contribution) it was discovered this cannot be added after the fact for org-based forks, only user-based. As there's not a great reference link for this in the github docs that doesn't descend into a bunch of organization permissions management, I'm not calling this specific circumstance explicitly.
google-cla
bot
added
the
cla: yes
codyoss
approved these changes
Jul 21, 2020
tbpg
approved these changes
Jul 21, 2020
shollyman
added
the
automerge
tritone
pushed a commit
to tritone/google-cloud-go
that referenced
this pull request
Aug 25, 2020
Adds an explicit mention to enable "Allow edits by maintainers" when setting up the pull request. In PR googleapis#2574 (external contribution) it was discovered this cannot be added after the fact for org-based forks, only user-based. As there's not a great reference link for this in the github docs that doesn't descend into a bunch of organization permissions management, I'm not calling this specific circumstance explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an explicit mention to enable "Allow edits by maintainers" when
setting up the pull request. In PR #2574 (external contribution) it was
discovered this cannot be added after the fact for org-based forks, only
user-based.
As there's not a great reference link for this in the github docs that
doesn't descend into a bunch of organization permissions management, I'm
not calling this specific circumstance explicitly.