bigqueryNullFloat64 add +Inf, -Inf and NaN support #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated PR for equality checks instead of HasPefix. - Added dedicated NullFloat64 tests.
Merge Changes to User Fork
google-cla
bot
added
the
cla: yes
shollyman
approved these changes
Jul 20, 2020
shollyman
added
automerge
kokoro-team
removed
the
kokoro:force-run
|
@shollyman Thanks for getting this merged! Do you know the release/tagging cadence for BigQuery? eager to switch back to the upstream repo instead of my fork :) |
|
I'll see about getting a release cut this week. |
tritone
pushed a commit
to tritone/google-cloud-go
that referenced
this pull request
Aug 25, 2020
This is a new PR for closed PR googleapis#2574 because you can only allow edits for maintainers on user-forks and NOT organization forks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new PR for closed PR #2574 because you can only allow edits for maintainers on user-forks and NOT organization forks.