Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): add support for NUMERIC data type #2415

Merged
merged 7 commits into from Sep 9, 2020
Merged

feat(spanner): add support for NUMERIC data type #2415

merged 7 commits into from Sep 9, 2020

Conversation

hengfengli
Copy link
Contributor

No description provided.

@hengfengli hengfengli added api: spanner Issues related to the Spanner API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 10, 2020
@hengfengli hengfengli self-assigned this Jun 10, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 10, 2020
@skuruppu skuruppu requested a review from larkee July 23, 2020 05:01
larkee
larkee reviewed Jul 27, 2020
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple questions about decodeValue 👍

spanner/value.go Outdated Show resolved Hide resolved
spanner/value.go Show resolved Hide resolved
spanner/value.go Outdated Show resolved Hide resolved
larkee
larkee approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codyoss codyoss changed the title spanner: add support for NUMERIC data type feat(spanner): add support for NUMERIC data type Aug 18, 2020
@hengfengli hengfengli merged commit 7430d72 into googleapis:master Sep 9, 2020
@hengfengli hengfengli deleted the add-numeric-support branch September 9, 2020 00:03
@hengfengli hengfengli removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 9, 2020
@apstndb apstndb mentioned this pull request Sep 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees

@hengfengli hengfengli

Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hengfengli @larkee @googlebot