storage: endpoint port is dropped

[tbpg]

Client

Storage

Code

e.g.

	c, err := NewClient(ctx, option.WithEndpoint("example.com:8888"))

Expected behavior

Port is retained.

Actual behavior

Port is dropped.

Additional context

Behavior was added in 95bbb7d#diff-efc763a7d18657aa44c013131823cfc9R131.

Docs for (*url.URL).Hostname:

Hostname returns u.Host, stripping any valid port number if present.

Reported in #1619 (comment).

cc @tritone @broady

[tritone]

My mistake on this one; posted https://code-review.googlesource.com/c/gocloud/+/50891 with a fix.

[vikstrous]

Thanks for fixing. I couldn't verify the fix because both before and after the fix, there was no combination of options that worked for connecting to fake gcs storage backend. I'm using the following instead:

	addr := "127.0.0.1:4443"
	opt := option.WithHTTPClient(&http.Client{
		Transport: &http.Transport{
			DialTLS: func(string, string) (net.Conn, error) {
				return tls.Dial("tcp", addr, &tls.Config{
					InsecureSkipVerify: true,
				})
			},
		},
	})
	client, err := storage.NewClient(ctx, opt)