Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanner: Remove gRPC codes from error #1608

Closed
olavloite opened this issue Oct 8, 2019 · 1 comment
Closed

Spanner: Remove gRPC codes from error #1608

olavloite opened this issue Oct 8, 2019 · 1 comment
Assignees
@olavloite
Labels
api: spanner Issues related to the Spanner API. type: cleanup An internal cleanup or hygiene concern.

Comments

@olavloite
Copy link
Contributor

olavloite commented Oct 8, 2019 •
edited

Remove the assignment of gRPC codes to errors, as seen for example here and here. The only acceptable place to generate gRPC errors is gRPC.

Moved from #1418 to a separate issue.
@olavloite olavloite self-assigned this Oct 8, 2019
@olavloite olavloite added api: spanner Issues related to the Spanner API. type: cleanup An internal cleanup or hygiene concern. labels Oct 8, 2019
gopherbot pushed a commit that referenced this issue Dec 24, 2019
@olavloite
spanner: Use Go 1.13 error-unwrapping
9f47821 
Use Go 1.13 error-unwrapping and the equivalent xerrors features
for builds on versions < 1.13. This makes it possible to use
wrapped errors with the Spanner client.

This change also deprecates the gRPC code in the Spanner error struct.
All functions that need the gRPC code will extract it from the wrapped
error instead of reading this field.

Fixes #1223 and #1608.
Updates #1310.

Change-Id: Iea914adb5ca78af5e78cc948d8b1180eb3d647d2
Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/48730
Reviewed-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hengfeng Li <hengfeng@google.com>
@skuruppu
Copy link
Contributor

skuruppu commented Feb 7, 2020

Seems like the issue is fixed in commit.

@olavloite please reopen if you think there's more work that needs to be done.

@skuruppu skuruppu closed this as completed Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the Spanner API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skuruppu @olavloite