Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudprofiler: Configurable sample rate #10050

Open
jonhayesverily opened this issue Apr 26, 2024 · 0 comments
Open

cloudprofiler: Configurable sample rate #10050

jonhayesverily opened this issue Apr 26, 2024 · 0 comments
Assignees
Labels
api: cloudprofiler Issues related to the Cloud Profiler API. samples Issues that are directly related to samples. triage me I really want to be triaged.

Comments

@jonhayesverily
Copy link

jonhayesverily commented Apr 26, 2024

Is your feature request related to a problem? Please describe.
There is no mechanism to configure (reduce) the sample rate of the profiler package, and thus reduce the number of update requests per minute to the Cloud Profiler API. The default GCP quota for Cloud Profiler API update requests is 100 per minute, and the profiler makes 1 update request per profile type per minute. So, 20-25 services in a single GCP project will hit this quota easily with default profile types (faster if you enable mutexes).

Describe the solution you'd like
The profiler.Config type has a positive integer SampleRate field that allows you to specify the number of minutes between samples (default, minimum 1).

Describe alternatives you've considered
Increasing GCP quota for the API

@jonhayesverily jonhayesverily added the triage me I really want to be triaged. label Apr 26, 2024
@jonhayesverily jonhayesverily changed the title profiler: Configurable sample rate cloudprofiler: Configurable sample rate Apr 26, 2024
@product-auto-label product-auto-label bot added api: cloudprofiler Issues related to the Cloud Profiler API. samples Issues that are directly related to samples. labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudprofiler Issues related to the Cloud Profiler API. samples Issues that are directly related to samples. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants