diff --git a/batch/apiv1/batchpb/batch.pb.go b/batch/apiv1/batchpb/batch.pb.go index 5d0ebc4becf..a3bde553b56 100644 --- a/batch/apiv1/batchpb/batch.pb.go +++ b/batch/apiv1/batchpb/batch.pb.go @@ -52,8 +52,9 @@ type CreateJobRequest struct { // Pattern: "projects/{project}/locations/{location}" Parent string `protobuf:"bytes,1,opt,name=parent,proto3" json:"parent,omitempty"` // ID used to uniquely identify the Job within its parent scope. - // This field should contain at most 63 characters. - // Only alphanumeric characters or '-' are accepted. + // This field should contain at most 63 characters and must start with + // lowercase characters. + // Only lowercase characters, numbers and '-' are accepted. // The '-' character cannot be the first or the last one. // A system generated ID will be used if the field is not set. // diff --git a/batch/apiv1/batchpb/job.pb.go b/batch/apiv1/batchpb/job.pb.go index f860b9f0899..6f45be1065f 100644 --- a/batch/apiv1/batchpb/job.pb.go +++ b/batch/apiv1/batchpb/job.pb.go @@ -1287,7 +1287,7 @@ func (*AllocationPolicy_Disk_Image) isAllocationPolicy_Disk_DataSource() {} func (*AllocationPolicy_Disk_Snapshot) isAllocationPolicy_Disk_DataSource() {} -// A new or an existing persistent disk or a local ssd attached to a VM +// A new or an existing persistent disk (PD) or a local ssd attached to a VM // instance. type AllocationPolicy_AttachedDisk struct { state protoimpl.MessageState @@ -1383,7 +1383,7 @@ func (*AllocationPolicy_AttachedDisk_NewDisk) isAllocationPolicy_AttachedDisk_At func (*AllocationPolicy_AttachedDisk_ExistingDisk) isAllocationPolicy_AttachedDisk_Attached() {} -// Accelerator describes Compute Engine accelerators to be attached to VMs. +// Accelerator describes Compute Engine accelerators to be attached to the VM. type AllocationPolicy_Accelerator struct { state protoimpl.MessageState sizeCache protoimpl.SizeCache @@ -1471,10 +1471,9 @@ type AllocationPolicy_InstancePolicy struct { // The provisioning model. ProvisioningModel AllocationPolicy_ProvisioningModel `protobuf:"varint,4,opt,name=provisioning_model,json=provisioningModel,proto3,enum=google.cloud.batch.v1.AllocationPolicy_ProvisioningModel" json:"provisioning_model,omitempty"` // The accelerators attached to each VM instance. - // Not yet implemented. Accelerators []*AllocationPolicy_Accelerator `protobuf:"bytes,5,rep,name=accelerators,proto3" json:"accelerators,omitempty"` // Non-boot disks to be attached for each VM created by this InstancePolicy. - // New disks will be deleted when the attached VM is deleted. + // New disks will be deleted when the VM is deleted. Disks []*AllocationPolicy_AttachedDisk `protobuf:"bytes,6,rep,name=disks,proto3" json:"disks,omitempty"` } diff --git a/batch/apiv1/batchpb/task.pb.go b/batch/apiv1/batchpb/task.pb.go index e8c972ff3ff..1fa9e0abfd5 100644 --- a/batch/apiv1/batchpb/task.pb.go +++ b/batch/apiv1/batchpb/task.pb.go @@ -898,11 +898,11 @@ type Runnable_Container struct { // 'goog-internal'. BlockExternalNetwork bool `protobuf:"varint,9,opt,name=block_external_network,json=blockExternalNetwork,proto3" json:"block_external_network,omitempty"` // Optional username for logging in to a docker registry. If username - // matches `projects/*/secrets/*/versions/*` then Batch will read the + // matches "projects/*/secrets/*/versions/*" then Batch will read the // username from the Secret Manager. Username string `protobuf:"bytes,10,opt,name=username,proto3" json:"username,omitempty"` // Optional password for logging in to a docker registry. If password - // matches `projects/*/secrets/*/versions/*` then Batch will read the + // matches "projects/*/secrets/*/versions/*" then Batch will read the // password from the Secret Manager; Password string `protobuf:"bytes,11,opt,name=password,proto3" json:"password,omitempty"` } diff --git a/batch/apiv1/batchpb/volume.pb.go b/batch/apiv1/batchpb/volume.pb.go index 20aa17e2825..d1a49a5665b 100644 --- a/batch/apiv1/batchpb/volume.pb.go +++ b/batch/apiv1/batchpb/volume.pb.go @@ -35,9 +35,7 @@ const ( _ = protoimpl.EnforceVersion(protoimpl.MaxVersion - 20) ) -// Volume and mount parameters to be associated with a TaskSpec. A TaskSpec -// might describe zero, one, or multiple volumes to be mounted as part of the -// task. +// Volume describes a volume and parameters for it to be mounted to a VM. type Volume struct { state protoimpl.MessageState sizeCache protoimpl.SizeCache @@ -51,16 +49,17 @@ type Volume struct { // *Volume_Gcs // *Volume_DeviceName Source isVolume_Source `protobuf_oneof:"source"` - // Mount path for the volume, e.g. /mnt/share + // The mount path for the volume, e.g. /mnt/disks/share. MountPath string `protobuf:"bytes,4,opt,name=mount_path,json=mountPath,proto3" json:"mount_path,omitempty"` - // Mount options - // For Google Cloud Storage, mount options are the global options supported by - // gcsfuse tool. Batch will use them to mount the volume with the following - // command: - // "gcsfuse [global options] bucket mountpoint". - // For PD, NFS, mount options are these supported by /etc/fstab. Batch will - // use Fstab to mount such volumes. - // https://help.ubuntu.com/community/Fstab + // For Google Cloud Storage (GCS), mount options are the options supported by + // the gcsfuse tool (https://github.com/GoogleCloudPlatform/gcsfuse). + // For existing persistent disks, mount options provided by the + // mount command (https://man7.org/linux/man-pages/man8/mount.8.html) except + // writing are supported. This is due to restrictions of multi-writer mode + // (https://cloud.google.com/compute/docs/disks/sharing-disks-between-vms). + // For other attached disks and Network File System (NFS), mount options are + // these supported by the mount command + // (https://man7.org/linux/man-pages/man8/mount.8.html). MountOptions []string `protobuf:"bytes,5,rep,name=mount_options,json=mountOptions,proto3" json:"mount_options,omitempty"` } @@ -143,17 +142,22 @@ type isVolume_Source interface { } type Volume_Nfs struct { - // An NFS source for the volume (could be a Filestore, for example). + // A Network File System (NFS) volume. For example, a + // Filestore file share. Nfs *NFS `protobuf:"bytes,1,opt,name=nfs,proto3,oneof"` } type Volume_Gcs struct { - // A Google Cloud Storage source for the volume. + // A Google Cloud Storage (GCS) volume. Gcs *GCS `protobuf:"bytes,3,opt,name=gcs,proto3,oneof"` } type Volume_DeviceName struct { - // Device name of an attached disk + // Device name of an attached disk volume, which should align with a + // device_name specified by + // job.allocation_policy.instances[0].policy.disks[i].device_name or + // defined by the given instance template in + // job.allocation_policy.instances[0].instance_template. DeviceName string `protobuf:"bytes,6,opt,name=device_name,json=deviceName,proto3,oneof"` } @@ -163,15 +167,15 @@ func (*Volume_Gcs) isVolume_Source() {} func (*Volume_DeviceName) isVolume_Source() {} -// Represents an NFS server and remote path: : +// Represents an NFS volume. type NFS struct { state protoimpl.MessageState sizeCache protoimpl.SizeCache unknownFields protoimpl.UnknownFields - // URI of the NFS server, e.g. an IP address. + // The IP address of the NFS. Server string `protobuf:"bytes,1,opt,name=server,proto3" json:"server,omitempty"` - // Remote source path exported from NFS, e.g., "/share". + // Remote source path exported from the NFS, e.g., "/share". RemotePath string `protobuf:"bytes,2,opt,name=remote_path,json=remotePath,proto3" json:"remote_path,omitempty"` } @@ -221,7 +225,7 @@ func (x *NFS) GetRemotePath() string { return "" } -// Represents a Google Cloud Storage volume source config. +// Represents a Google Cloud Storage volume. type GCS struct { state protoimpl.MessageState sizeCache protoimpl.SizeCache diff --git a/dialogflow/cx/apiv3beta1/cxpb/security_settings.pb.go b/dialogflow/cx/apiv3beta1/cxpb/security_settings.pb.go index 7669a186ea5..f3f824e1263 100644 --- a/dialogflow/cx/apiv3beta1/cxpb/security_settings.pb.go +++ b/dialogflow/cx/apiv3beta1/cxpb/security_settings.pb.go @@ -808,9 +808,10 @@ type SecuritySettings_RetentionWindowDays struct { // Retains data in interaction logging for the specified number of days. // This does not apply to Cloud logging, which is owned by the user - not // Dialogflow. - // User must set a value lower than Dialogflow's default 365d TTL (time to - // live). Setting a value higher than that has no effect. A missing value or - // setting to 0 also means we use Dialogflow's default TTL. + // User must set a value lower than Dialogflow's default 365d TTL (30 days + // for Agent Assist traffic), higher value will be ignored and use default. + // Setting a value higher than that has no effect. A missing value or + // setting to 0 also means we use default TTL. RetentionWindowDays int32 `protobuf:"varint,6,opt,name=retention_window_days,json=retentionWindowDays,proto3,oneof"` }