Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require cryptography in packaging metadata (and remove rsa) #941

Open
ktdreyer opened this issue Jan 12, 2022 · 3 comments · May be fixed by #942
Open

require cryptography in packaging metadata (and remove rsa) #941

ktdreyer opened this issue Jan 12, 2022 · 3 comments · May be fixed by #942
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ktdreyer
Copy link

In #185 , google-auth now uses Python's cryptography library if it's available.

The cryptography library is faster and better-maintained than python-rsa.

Recently the rsa library had a security bug, and it took a long time to ship an update sybrenstuvel/python-rsa#165 . This impacted google-auth users, see #646

Would you please update the google-auth packaging metadata to stop installing rsa and start installing cryptography instead?

@ktdreyer
Copy link
Author

(CC @jmontleon FYI, since you're packaging google-auth in Fedora)

@jmontleon
Copy link

Thanks for the heads up. Is there a minimum version required? It looks like in Fedora 35 we have python3-cryptography-35.0.0-2.fc35.x86_64, Fedora 34 python-cryptography-3.4.6-1.fc34, and in EL8 and EL9, which I've also been trying to keep up to date, we have python3-cryptography-3.2.1-5.el8.x86_64 and python3-cryptography-3.4.7-5.el9.x86_64.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jan 13, 2022
@parthea parthea added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Jan 13, 2022
@ktdreyer ktdreyer linked a pull request Jan 13, 2022 that will close this issue
@ktdreyer
Copy link
Author

The cryptography backend went into google-auth-1.4.0, tagged Feb 08, 2018.

At that time, the latest cryptography release was 2.1.4. So we should be fine for Fedora and EPEL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants