Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests fail with cryptography >= 39.0.0 when using python 3.7 #1440

Open
parthea opened this issue Dec 14, 2023 · 1 comment
Open

Unit tests fail with cryptography >= 39.0.0 when using python 3.7 #1440

parthea opened this issue Dec 14, 2023 · 1 comment

Comments

@parthea
Copy link
Contributor

parthea commented Dec 14, 2023

See build log here where python 3.7 unit tests fail when using cryptography >= 39.0.0

============================= test session starts ==============================
platform linux -- Python 3.7.17, pytest-7.4.3, pluggy-1.2.0
rootdir: /tmpfs/src/github/google-auth-library-python
plugins: asyncio-0.21.1, localserver-0.8.1, cov-4.1.0
asyncio: mode=strict
collected 1253 items / 1 error

==================================== ERRORS ====================================
_________ ERROR collecting tests/transport/test__custom_tls_signer.py __________
ImportError while importing test module '/tmpfs/src/github/google-auth-library-python/tests/transport/test__custom_tls_signer.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/transport/test__custom_tls_signer.py:21: in 
    import urllib3.contrib.pyopenssl  # type: ignore
.nox/unit-3-7/lib/python3.7/site-packages/urllib3/contrib/pyopenssl.py:49: in 
    from cryptography.hazmat.backends.openssl.x509 import _Certificate
E   ModuleNotFoundError: No module named 'cryptography.hazmat.backends.openssl.x509'
=============================== warnings summary ===============================
parthea added a commit to renovate-bot/google-auth-library-python that referenced this issue Dec 14, 2023
@clundin25
Copy link
Contributor

@parthea Since we have entered a release freeze until Jan 2nd, maybe we can just remove the Python 3.7 jobs? The deprecation indicates it can be removed on Jan 1st.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants