Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid deprecated "out-of-band" authentication flow #186

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Mar 14, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #184 🦕

Sorry, something went wrong.

@tswast tswast requested a review from a team as a code owner March 14, 2022 21:50
@tswast
Copy link
Contributor Author

tswast commented Mar 14, 2022

Note: this code is pulled from pydata-google-auth, but I was the sole author of the module and tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_user_credentials needs to migrate away from OOB flow
2 participants