pack and install: "after each" hook: cleanup staging for "should be able to webpack the library" failed

[flaky-bot]

Note: #1415 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

---

commit: 89daaac
buildURL: Build Status, Sponge
status: failed

Test output

ENOTEMPTY: directory not empty, rmdir '/tmp/tmp-130-if4OANDyeyE0/node_modules'
Error: ENOTEMPTY: directory not empty, rmdir '/tmp/tmp-130-if4OANDyeyE0/node_modules'
    at Object.rmdirSync (fs.js:850:3)
    at rmkidsSync (node_modules/rimraf/rimraf.js:349:27)
    at rmdirSync (node_modules/rimraf/rimraf.js:329:7)
    at rimrafSync (node_modules/rimraf/rimraf.js:301:9)
    at /workspace/node_modules/rimraf/rimraf.js:336:39
    at Array.forEach ()
    at rmkidsSync (node_modules/rimraf/rimraf.js:336:26)
    at rmdirSync (node_modules/rimraf/rimraf.js:329:7)
    at rimrafSync (node_modules/rimraf/rimraf.js:301:9)
    at Object._cleanupCallback [as removeCallback] (node_modules/tmp/lib/tmp.js:356:16)
    at Context. (build/system-test/test.kitchen.js:70:24)
        -> /workspace/system-test/test.kitchen.ts:74:18
    at processImmediate (internal/timers.js:461:21)

[bcoe]

Feel free to assign back to me if you don't have time, just doing triage.

I believe this will be a really small tweak, where we maybe just need to provide the recursive flag?

[danielbankhead]

Thanks! Will get to this shortly

[danielbankhead]

Strange, we currently set recursive as true (effectively):

google-auth-library-nodejs/system-test/test.kitchen.ts

Line 34 in 74a9fff

stagingDir = tmp.dirSync({keep, unsafeCleanup: true});

[danielbankhead]

Related discussion: raszi/node-tmp#276

I'll refactor and remove this dependency altogether using native tools, e.g. fsPromises.mkdtemp