Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(yargs-parser): updates the yargs-parser dependency #2326

Merged
merged 3 commits into from Aug 11, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Aug 11, 2020

As of v19, yargs-parser is now shipping its own types.

The types seem to be working fairly well in our codebase, with the hiccup that one type was corrected, _ can be a number or string.

node example.mjs apple 99 batman
{ _: [ 'apple', 99, 'batman' ] }

FYI, yargs-parser now supports ESM:

import parser from 'yargs-parser'

console.info(parser(process.argv.slice(2)))

and Deno 馃槷

import parser from "https://deno.land/x/yargs_parser/deno.ts";

const argv = parser('--foo=99 --bar=9987930', {
  string: ['bar']
})
console.log(argv)

@bcoe bcoe requested a review from a team as a code owner August 11, 2020 02:12
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2020
@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #2326 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2326   +/-   ##
=======================================
  Coverage   85.72%   85.72%           
=======================================
  Files          11       11           
  Lines        1709     1709           
  Branches      135      135           
=======================================
  Hits         1465     1465           
  Misses        244      244           
Impacted Files Coverage 螖
src/generator/generator.ts 55.32% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 701edf3...31c65a8. Read the comment docs.

@JustinBeckwith JustinBeckwith added the automerge Merge the pull request once unit tests and other checks pass. label Aug 11, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit ac1f487 into master Aug 11, 2020
@JustinBeckwith JustinBeckwith deleted the update-yargs-parser branch December 13, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants