fix: update and declare commons-codec dependency #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suztomo
approved these changes
Nov 29, 2022
| @@ -203,6 +203,11 @@ | |||
| <artifactId>google-api-client-xml</artifactId> | |||
| <version>${project.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>commons-codec</groupId> | |||
There was a problem hiding this comment.
Can you add source code comment why it's declared? Such as "org.apache.httpcomponents:httpclient:4.5.x declares an outdated version of commons-codec"
blakeli0
pushed a commit
that referenced
this pull request
Dec 16, 2022
blakeli0
pushed a commit
that referenced
this pull request
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR manually declares the
commons-codecversion to1.15.It was discovered that
commons-codec-1.11.jarhas a a medium vulnerability (https://sca.analysiscenter.veracode.com/vulnerability-database/security/sca/vulnerability/sid-22742/summary). This vulnerability does not have a CVE and it is related to Insecure Input Validation and encoding.This is an indirect dpendency that the API client library uses indirectly by using Apache HttpClient.
Any version of codec v1.13+ should have the fix for this vulnerability.