ci: installing google-play-services artifact for Windows #1706

suztomo · 2021-02-11T18:39:02Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #1705 ☕️

suztomo · 2021-02-11T18:43:07Z

92a180b failed:

wget: D:\a\_temp\e1fca20a-80ef-4a04-9b5e-b66495e66e06.ps1:4
Line |
   4 |  wget https://dl.google.com/dl/android/maven2/com/google/android/gms/p …
     |  ~~~~
     | The term 'wget' is not recognized as a name of a cmdlet, function, script file, or executable program.
     | Check the spelling of the name, or if a path was included, verify that the path is correct and try
     | again.

codecov · 2021-02-11T18:48:21Z

Codecov Report

Merging #1706 (f5f016c) into master (922af40) will not change coverage.
The diff coverage is n/a.

@@      Coverage Diff       @@
##   master   #1706   +/-   ##
==============================
==============================

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922af40...472d361. Read the comment docs.

suztomo · 2021-02-11T19:03:23Z

4af8b2c fails:

Error:  The goal you specified requires a project to execute but there is no POM in this directory (D:\a\google-api-java-
client\google-api-java-client\play-services). Please verify you invoked Maven from the correct directory. -> [Help 1]

suztomo · 2021-02-11T19:19:17Z

"shell: bash" seems working for windows-latest.

suztomo · 2021-02-11T20:42:26Z

000d56d failed with checkstyle violation.

...
[INFO] --- maven-checkstyle-plugin:3.1.2:check (default) @ google-api-client-servlet ---
Warning:  Old version of checkstyle detected. Consider updating to >= v8.30
Warning:  For more information see: https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html
...
Error:  D:\a\google-api-java-client\google-api-java-client\google-api-client-servlet\src\main\java\com\google\api\client\googleapis\extensions\servlet\notifications\NotificationServlet.java:55: Line is longer than 100 characters (found 113). [LineLength]
Error:  D:\a\google-api-java-client\google-api-java-client\google-api-client-servlet\src\main\java\com\google\api\client\googleapis\extensions\servlet\notifications\NotificationServlet.java:72: Line is longer than 100 characters (found 162). [LineLength]
Audit done.
[INFO] There are 2 errors reported by Checkstyle 8.23 with checkstyle.xml ruleset.
Error:  src\main\java\com\google\api\client\googleapis\extensions\servlet\notifications\NotificationServlet.java:[55] (sizes) LineLength: Line is longer than 100 characters (found 113).
Error:  src\main\java\com\google\api\client\googleapis\extensions\servlet\notifications\NotificationServlet.java:[72] (sizes) LineLength: Line is longer than 100 characters (found 162).
...

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Parent for the Google API Client Library for Java 1.31.2:
[INFO] 
[INFO] Parent for the Google API Client Library for Java .. SUCCESS [  3.553 s]
[INFO] Google APIs Client Library for Java ................ SUCCESS [ 14.844 s]
[INFO] Servlet and JDO extensions to the Google API Client Library for Java. FAILURE [  1.824 s]
[INFO] Android Platform Extensions to the Google APIs Client Library for Java. SUCCESS [  5.274 s]
[INFO] Google App Engine extensions to the Google API Client Library for Java. SKIPPED
[INFO] GSON extensions to the Google APIs Client Library for Java SUCCESS [  1.872 s]
[INFO] Jackson 2 extensions to the Google APIs Client Library for Java SKIPPED
[INFO] Java 6 (and higher) Extensions to the Google API Client Library for Java. SKIPPED
[INFO] Protocol Buffer extensions to the Google APIs Client Library for Java SKIPPED
[INFO] XML extensions to the Google APIs Client Library for Java SUCCESS [  4.409 s]
[INFO] Assembly for the Google APIs Client Library for Java SKIPPED
[INFO] Google API Client Library for Java BOM ............. SUCCESS [  0.300 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  21.799 s (Wall Clock)
[INFO] Finished at: 2021-02-11T19:20:34Z
[INFO] ------------------------------------------------------------------------
Error:  Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (default) on project google-api-client-servlet: You have 2 Checkstyle violations. -> [Help 1]

The file has long lines in <pre> element:

Why does this fail only in Windows?

suztomo · 2021-02-11T21:16:13Z

The multi-line with bash (10a5b9a) works. Working on fixing the checkstyle problem.

suztomo · 2021-02-11T21:28:21Z

checkstyle-suppressions.xml includes com/google/api/client/googleapis/extensions/servlet/notifications/NotificationServlet.java. Doesn't this work for Windows build?

suztomo · 2021-02-11T21:44:55Z

5d112be failed with

Error:  Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (default) on project google-api-
client-parent: Failed during checkstyle configuration: cannot initialize module TreeWalker - cannot initialize module 
JavadocMethod - Property 'allowUndeclaredRTE' does not exist, please check the documentation -> [Help 1]

To allow documented java.lang.RuntimeExceptions that are not declared, set property allowUndeclaredRTE to true.

https://checkstyle.sourceforge.io/version/4.4/5.x/config_javadoc.html

Other errors on properties that no longer exist

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (default) on project google-
api-client-parent: Failed during checkstyle configuration: cannot initialize module TreeWalker - cannot initialize module 
JavadocMethod - Property 'allowThrowsTagsForSubclasses' does not exist, please check the documentation -> [Help 1]

The configuration file structure also changed:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (default) on project google-
api-client-parent: Failed during checkstyle configuration: cannot initialize module TreeWalker - TreeWalker is not allowed as a
 parent of LineLength Please review 'Parent Module' section for this Check in web documentation if Check is standard. -> [Help 1]

https://checkstyle.org/config_sizes.html#LineLength_Parent_Module says the parent is "Check" module.

suztomo · 2021-02-11T21:54:17Z

43d9e56 failed with checkstyle error:

[INFO] --- maven-checkstyle-plugin:3.1.2:check (default) @ google-api-client ---
[INFO] Starting audit...
Error:  D:\a\google-api-java-client\google-api-java-client\google-api-client\src\main\java\com\google\api
\client\googleapis\apache\GoogleApacheHttpTransport.java:1: Expected line ending for file
 is LF(\n), but CRLF(\r\n) is detected. [NewlineAtEndOfFile]
Error:  D:\a\google-api-java-client\google-api-java-client\google-api-client\src\main\java\com\google\api
\client\googleapis\apache\package-info.java:1: Expected line ending for file is LF(\n), but
 CRLF(\r\n) is detected. [NewlineAtEndOfFile]
Error:  D:\a\google-api-java-client\google-api-java-client\google-api-client\src\main\java\com\google\api
\client\googleapis\apache\v2\GoogleApacheHttpTransport.java:1: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected. [NewlineAtEndOfFile]

My IntelliJ shows the file uses LF. It seems that there's some process that converts LF to CRLF for windows.

suztomo · 2021-02-11T22:42:22Z

It passed!

suztomo · 2021-02-11T22:43:00Z

.github/workflows/ci.yaml

+    - name: git configuration to avoid automatic CRLF conversion
+      run: |
+        git config --global core.autocrlf false
+        git config --global core.eol lf


This avoids the error below:

[INFO] --- maven-checkstyle-plugin:3.1.2:check (default) @ google-api-client --- [INFO] Starting audit... Error: D:\a\google-api-java-client\google-api-java-client\google-api-client\src\main\java\com\google\api \client\googleapis\apache\GoogleApacheHttpTransport.java:1: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected. [NewlineAtEndOfFile] Error: D:\a\google-api-java-client\google-api-java-client\google-api-client\src\main\java\com\google\api \client\googleapis\apache\package-info.java:1: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected. [NewlineAtEndOfFile] Error: D:\a\google-api-java-client\google-api-java-client\google-api-client\src\main\java\com\google\api \client\googleapis\apache\v2\GoogleApacheHttpTransport.java:1: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected. [NewlineAtEndOfFile]

suztomo · 2021-02-11T22:43:37Z

.github/workflows/ci.yaml

+      shell: bash
+      run: |
+        mkdir play-services
+        cd play-services
+        curl --output play-services-basement-8.3.0.aar https://dl.google.com/dl/android/maven2/com/google/android/gms/play-services-basement/8.3.0/play-services-basement-8.3.0.aar
+        unzip play-services-basement-8.3.0.aar
+        mvn install:install-file \
+            -Dfile=classes.jar \
+            -DgroupId=com.google.android.google-play-services \
+            -DartifactId=google-play-services \
+            -Dversion=1 \
+            -Dpackaging=jar
+    - run: .kokoro/build.sh
+      shell: bash


Windows has bash.

suztomo · 2021-02-11T22:44:03Z

checkstyle-suppressions.xml

-  <suppress checks="LineLength" files="com/google/api/client/googleapis/apache/GoogleApacheHttpTransport.java"/>
-  <suppress checks="LineLength" files="com/google/api/client/googleapis/extensions/appengine/notifications/AppEngineNotificationServlet.java"/>
-  <suppress checks="LineLength" files="com/google/api/client/googleapis/extensions/appengine/subscriptions/package-info.java"/>
-  <suppress checks="LineLength" files="com/google/api/client/googleapis/extensions/servlet/notifications/NotificationServlet.java"/>
-  <suppress checks="LineLength" files="com/google/api/client/googleapis/javanet/GoogleNetHttpTransport.java"/>
-  <suppress checks="LineLength" files="com/google/api/client/googleapis/subscriptions/NotificationHeaders.java"/>


Files that no longer violates the line length have been removed.

suztomo · 2021-02-11T22:45:50Z

checkstyle-suppressions.xml

+  <suppress checks="LineLength" files="com[/\\]google[/\\]api[/\\]client[/\\]googleapis[/\\]extensions[/\\]appengine[/\\]notifications[/\\]AppEngineNotificationServlet.java"/>
+  <suppress checks="LineLength" files="com[/\\]google[/\\]api[/\\]client[/\\]googleapis[/\\]extensions[/\\]servlet[/\\]notifications[/\\]NotificationServlet.java"/>


I had to add forward slash and back slash to make it work for both Windows and Unix filesystem.

suztomo · 2021-02-11T22:46:08Z

checkstyle.xml

-      <property name="allowMissingJavadoc" value="true"/>
      <property name="allowMissingParamTags" value="true"/>
      <property name="allowMissingReturnTag" value="true"/>
-      <property name="allowMissingThrowsTags" value="true"/>
-      <property name="allowThrowsTagsForSubclasses" value="true"/>
-      <property name="allowUndeclaredRTE" value="true"/>
    </module>


The removed properties are no longer supported in newer version of checkstyle.

suztomo · 2021-02-11T22:46:28Z

checkstyle.xml

@@ -183,22 +179,6 @@ page at http://checkstyle.sourceforge.net/config.html -->

    -->

-    <module name="LineLength">


The LineLength's parent has to be "Check" element in the newer checkstyle.

suztomo · 2021-02-11T22:47:14Z

pom.xml

@@ -561,7 +561,7 @@
              <dependency>
                <groupId>com.puppycrawl.tools</groupId>
                <artifactId>checkstyle</artifactId>
-                <version>8.23</version>
+                <version>8.39</version>


This is the version google-cloud-shared-config 0.10.0 uses.

* chore(java): pom generation to look at root versions.txt * not to include irrelevant modules in monorepo Co-authored-by: Burke Davison <40617934+burkedavison@users.noreply.github.com> Co-authored-by: Burke Davison <40617934+burkedavison@users.noreply.github.com> Source-Link: googleapis/synthtool@909f3c8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:a57d2ea6d1a77aa96c17ad0850b779ec6295f88b6c1da3d214b2095d140a2066

* chore(java): pom generation to look at root versions.txt * not to include irrelevant modules in monorepo Co-authored-by: Burke Davison <40617934+burkedavison@users.noreply.github.com> Co-authored-by: Burke Davison <40617934+burkedavison@users.noreply.github.com> Source-Link: googleapis/synthtool@909f3c8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:a57d2ea6d1a77aa96c17ad0850b779ec6295f88b6c1da3d214b2095d140a2066 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Burke Davison <40617934+burkedavison@users.noreply.github.com>

ci: installing google-play-services artifact for Windows

92a180b

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 11, 2021

suztomo added 3 commits February 11, 2021 13:50

ci: trying Invoke-WebRequest

b9487eb

ci: cont line characters

851a0fd

ci: make mvn command in one line

4af8b2c

ci: using Windows bash

000d56d

suztomo added 2 commits February 11, 2021 15:51

ci: trying multi-line and shell for build.sh

10a5b9a

ci: upgrading checkstyle dependency

3aa146f

ci: updating checkstyle version

5d112be

ci: upgraded checkstyle version

43d9e56

suztomo added 3 commits February 11, 2021 16:57

ci: turning off auto-crlf conversion for checkout action

4ec4bd2

ci: cleanup suppressions file filter

d19f562

ci: specifying file path that works both windows and unix

472d361

suztomo commented Feb 11, 2021

View reviewed changes

suztomo marked this pull request as ready for review February 11, 2021 22:47

suztomo requested a review from a team as a code owner February 11, 2021 22:47

suztomo requested review from chingor13, elharo and Neenu1995 February 11, 2021 22:47

elharo approved these changes Feb 11, 2021

View reviewed changes

suztomo merged commit 60cce2a into googleapis:master Feb 12, 2021

suztomo deleted the windows_build branch February 12, 2021 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: installing google-play-services artifact for Windows #1706

ci: installing google-play-services artifact for Windows #1706

suztomo commented Feb 11, 2021 •

edited

suztomo commented Feb 11, 2021

codecov bot commented Feb 11, 2021 •

edited

suztomo commented Feb 11, 2021

suztomo commented Feb 11, 2021

suztomo commented Feb 11, 2021 •

edited

suztomo commented Feb 11, 2021

suztomo commented Feb 11, 2021

suztomo commented Feb 11, 2021 •

edited

suztomo commented Feb 11, 2021

suztomo commented Feb 11, 2021

suztomo Feb 11, 2021

suztomo Feb 11, 2021

suztomo Feb 11, 2021

suztomo Feb 11, 2021

suztomo Feb 11, 2021

suztomo Feb 11, 2021

suztomo Feb 11, 2021

		<suppress checks="LineLength" files="com[/\\]google[/\\]api[/\\]client[/\\]googleapis[/\\]extensions[/\\]appengine[/\\]notifications[/\\]AppEngineNotificationServlet.java"/>
		<suppress checks="LineLength" files="com[/\\]google[/\\]api[/\\]client[/\\]googleapis[/\\]extensions[/\\]servlet[/\\]notifications[/\\]NotificationServlet.java"/>

		@@ -183,22 +179,6 @@ page at http://checkstyle.sourceforge.net/config.html -->

		-->

		<module name="LineLength">

ci: installing google-play-services artifact for Windows #1706

ci: installing google-play-services artifact for Windows #1706

Conversation

suztomo commented Feb 11, 2021 • edited

suztomo commented Feb 11, 2021

codecov bot commented Feb 11, 2021 • edited

Codecov Report

suztomo commented Feb 11, 2021

suztomo commented Feb 11, 2021

suztomo commented Feb 11, 2021 • edited

suztomo commented Feb 11, 2021

suztomo commented Feb 11, 2021

suztomo commented Feb 11, 2021 • edited

suztomo commented Feb 11, 2021

suztomo commented Feb 11, 2021

suztomo Feb 11, 2021

Choose a reason for hiding this comment

suztomo Feb 11, 2021

Choose a reason for hiding this comment

suztomo Feb 11, 2021

Choose a reason for hiding this comment

suztomo Feb 11, 2021

Choose a reason for hiding this comment

suztomo Feb 11, 2021

Choose a reason for hiding this comment

suztomo Feb 11, 2021

Choose a reason for hiding this comment

suztomo Feb 11, 2021

Choose a reason for hiding this comment

suztomo commented Feb 11, 2021 •

edited

codecov bot commented Feb 11, 2021 •

edited

suztomo commented Feb 11, 2021 •

edited

suztomo commented Feb 11, 2021 •

edited