Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Create Integration Test for BYOID #908

Merged

Conversation

ScruffyProdigy
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 4, 2021
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
@codyoss codyoss changed the title feat: Create Integration Test for BYOID test: Create Integration Test for BYOID Mar 5, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more small things.

integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/integration_test.go Outdated Show resolved Hide resolved
integration-tests/byoid/setup.sh Outdated Show resolved Hide resolved
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Mar 5, 2021
@codyoss
Copy link
Member

codyoss commented Mar 5, 2021

LGTM, thanks!

@gcf-merge-on-green gcf-merge-on-green bot merged commit 63d6b3e into googleapis:master Mar 5, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 5, 2021
This was referenced Mar 10, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants