SafeBrowsing v5 only supports alt=proto

[lionello]

This should be "default": "proto":

google-api-go-client/safebrowsing/v5/safebrowsing-api.json

Line 40 in 9622a0d

"default": "json",

The currently generated SDK will always fail with HTTP 400, response:

{
  "error": {
    "code": 400,
    "message": "Unsupported Output Format",
    "status": "INVALID_ARGUMENT"
  }
}

Setting alt to "proto" doesn't work, since the SDK always decodes the response as JSON, failing with invalid character '\x12' looking for beginning of value trying to decode the protobuf as JSON.

[quartzmo]

APIs that publish clients to this repo should be sending JSON responses. If the SafeBrowsing v5 API is sending protobuf responses, that is incorrect. Can you provide a full dump of the response?

[lionello]

That JSON was the full dump of the response. I can capture the HTTP headers later.
When alt=json you always get that error JSON. The SafeBrowsing v5 API only handles requests when alt=proto.

[quartzmo]

Here is the discovery document for this API: https://safebrowsing.googleapis.com/$discovery/rest?version=v5

We will investigate further.

[quartzmo]

I believe the discovery document for this API (linked above) states that JSON is supported and is the default:

    "alt": {
      "enumDescriptions": [
        "Responses with Content-Type of application/json",
        "Media download with context-dependent Content-Type",
        "Responses with Content-Type of application/x-protobuf"
      ],
      "default": "json",
      "type": "string",
      "enum": [
        "json",
        "media",
        "proto"
      ],
      "location": "query",
      "description": "Data format for response."
    },

Therefore it appears that the service does not honor the contract of the discovery document.

@lionello Can you search the Cloud SQL issue tracker for an existing issue, and if not found, create a new issue demonstrating how the service does not support alt=json, then link that issue from here?

[codyoss]

Closing. As stated above this issue should be reported to the API service team.