Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(idtoken): add support for impersonated_service_account creds type #1792

Merged
merged 6 commits into from Jan 4, 2023

Conversation

adrianajg
Copy link
Contributor

@adrianajg adrianajg commented Dec 27, 2022

  • Allow NewTokenSource function to accept authorization credentials of type impersonated_service_account

Updates: #873

@google-cla
Copy link

google-cla bot commented Dec 27, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

idtoken/idtoken.go Outdated Show resolved Hide resolved
idtoken/idtoken.go Outdated Show resolved Hide resolved
idtoken/idtoken.go Outdated Show resolved Hide resolved
idtoken/idtoken.go Outdated Show resolved Hide resolved
idtoken/idtoken.go Outdated Show resolved Hide resolved
idtoken/idtoken_test.go Outdated Show resolved Hide resolved
idtoken/idtoken_test.go Outdated Show resolved Hide resolved
@adrianajg adrianajg changed the title feat(idtoken): NewTokenSource allows impersonated_service_account creds feat(idtoken): Make impersonated_service_account creds valid for NewTokenSource func Jan 3, 2023
@adrianajg adrianajg force-pushed the idtokenForIMpersonatedAccounts branch 2 times, most recently from 9ba99d9 to 3a1cc43 Compare January 3, 2023 16:06
@codyoss
Copy link
Member

codyoss commented Jan 3, 2023

@adrianajg It appears you have files that are not properly formatted

@codyoss codyoss changed the title feat(idtoken): Make impersonated_service_account creds valid for NewTokenSource func feat(idtoken): update NewTokenSource to support impersonated_service_account creds type Jan 3, 2023
@codyoss codyoss changed the title feat(idtoken): update NewTokenSource to support impersonated_service_account creds type feat(idtoken): add support for impersonated_service_account creds type Jan 3, 2023
idtoken/integration_test.go Outdated Show resolved Hide resolved
@adrianajg adrianajg force-pushed the idtokenForIMpersonatedAccounts branch from 3a1cc43 to 79b862a Compare January 3, 2023 21:34
Copy link
Contributor Author

@adrianajg adrianajg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed changes, let me know if you see anything else. Thanks!

idtoken/idtoken.go Outdated Show resolved Hide resolved
idtoken/idtoken.go Outdated Show resolved Hide resolved
idtoken/idtoken.go Outdated Show resolved Hide resolved
idtoken/idtoken.go Outdated Show resolved Hide resolved
idtoken/idtoken_test.go Outdated Show resolved Hide resolved
idtoken/idtoken_test.go Outdated Show resolved Hide resolved
idtoken/integration_test.go Outdated Show resolved Hide resolved
@googleapis googleapis deleted a comment from JohnsoNeal2013 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants