Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(idtoken): configure validator constructor to use no authentication by default #1789

Merged
merged 2 commits into from Jan 3, 2023

Conversation

adrianajg
Copy link
Contributor

@adrianajg adrianajg commented Dec 16, 2022

Fixes: #1682

@google-cla
Copy link

google-cla bot commented Dec 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codyoss
Copy link
Member

codyoss commented Dec 19, 2022

@adrianajg When you fix a bug it is a good idea to put the bug in the body of the commit. Would you update the body to say

"Fixes: #XXXX". This also allows Github to cross-ref these two items

@codyoss codyoss enabled auto-merge (squash) January 3, 2023 17:51
@codyoss codyoss merged commit b35900a into googleapis:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idtoken: validator uses ADC when it should not
2 participants