Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove uses of obsolete golang.org/x/xerrors #1776

Merged
merged 1 commit into from Dec 8, 2022

Conversation

thaJeztah
Copy link
Contributor

go1.13 and up now provide this functionality, and the xerrors.Is() function was deprecated.

Removing the dependency, as it was only used in a test.

go1.13 and up now provide this functionality, and the xerrors.Is()
function was deprecated.

Removing the dependency, as it was only used in a test.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah requested review from a team and yoshi-approver as code owners December 7, 2022 23:12
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codyoss codyoss added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Dec 7, 2022
@thaJeztah
Copy link
Contributor Author

You're welcome! Was digging through our dependencies to figure out why this was still in our dependency tree (so ploughing my way through various repositories 😂)

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Dec 8, 2022
@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Dec 8, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6193507 into googleapis:main Dec 8, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Dec 8, 2022
@thaJeztah thaJeztah deleted the remove_xerrors branch December 8, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants