Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(googleapi): inject gax apierror.APIError into googleapi.Error #1730

Merged
merged 12 commits into from Nov 7, 2022

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Oct 28, 2022

This PR depends on googleapis/gax-go#238.

@quartzmo
Copy link
Member Author

quartzmo commented Nov 2, 2022

I ran generation locally and it succeeds:

➜  google-api-go-generator git:(error-wrapping) make
go build -o google-api-go-generator
./google-api-go-generator -cache=false -install -api=* -gendir=..
2022/11/02 16:59:52 Generating API abusiveexperiencereport:v1
2022/11/02 16:59:53 Generating API acceleratedmobilepageurl:v1
2022/11/02 16:59:53 Generating API accessapproval:v1
2022/11/02 16:59:54 Generating API accesscontextmanager:v1beta
2022/11/02 16:59:55 Generating API accesscontextmanager:v1
...
2022/11/02 17:05:00 Generating API workflows:v1
2022/11/02 17:05:01 Generating API youtube:v3
2022/11/02 17:05:02 Generating API youtubeAnalytics:v2
2022/11/02 17:05:02 TODO writeSchemaCode for arrays for QueryResponseRows
2022/11/02 17:05:03 Generating API youtubereporting:v1
go test . -v
=== RUN   TestMedia
--- PASS: TestMedia (0.00s)
...
    --- PASS: TestDeprecatedPkgs/no_replacement_found,_package_not_in_map (0.00s)
    --- PASS: TestDeprecatedPkgs/no_replacement_found,_version_mismatch (0.00s)
PASS
ok      google.golang.org/api/google-api-go-generator   0.987s

@codyoss
Copy link
Member

codyoss commented Nov 3, 2022

@quartzmo Is this ready for review? If so, take it out of draft.

@quartzmo quartzmo marked this pull request as ready for review November 3, 2022 16:53
@quartzmo quartzmo requested review from a team and yoshi-approver as code owners November 3, 2022 16:53
@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2022
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small things

internal/gensupport/error_test.go Outdated Show resolved Hide resolved
internal/gensupport/error.go Outdated Show resolved Hide resolved
googleapi/googleapi.go Outdated Show resolved Hide resolved
internal/gensupport/error.go Outdated Show resolved Hide resolved
internal/gensupport/error.go Outdated Show resolved Hide resolved
@codyoss
Copy link
Member

codyoss commented Nov 7, 2022

Thanks! Lets be sure to regen everything in this PR as well

@quartzmo
Copy link
Member Author

quartzmo commented Nov 7, 2022

Will do. I did it once and stashed the results, but I'll rebase and do a fresh run.

@quartzmo quartzmo merged commit ee25e29 into googleapis:main Nov 7, 2022
@quartzmo quartzmo deleted the error-wrapping branch November 7, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants