New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(googleapi): inject gax apierror.APIError into googleapi.Error #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartzmo
force-pushed
the
error-wrapping
branch
2 times, most recently
from
November 2, 2022 21:50
a8fda07
to
04baf34
Compare
I ran generation locally and it succeeds:
|
@quartzmo Is this ready for review? If so, take it out of draft. |
quartzmo
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 3, 2022
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 3, 2022
codyoss
reviewed
Nov 3, 2022
codyoss
reviewed
Nov 3, 2022
codyoss
reviewed
Nov 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small things
codyoss
reviewed
Nov 7, 2022
quartzmo
force-pushed
the
error-wrapping
branch
from
November 7, 2022 16:57
6d631a7
to
e96b207
Compare
codyoss
approved these changes
Nov 7, 2022
Thanks! Lets be sure to regen everything in this PR as well |
Will do. I did it once and stashed the results, but I'll rebase and do a fresh run. |
quartzmo
force-pushed
the
error-wrapping
branch
from
November 7, 2022 18:01
e96b207
to
4e112bf
Compare
codyoss
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on googleapis/gax-go#238.