Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(internal/gensupport): use gax DetermineContentType #1716

Merged
merged 3 commits into from Oct 18, 2022
Merged

feat(internal/gensupport): use gax DetermineContentType #1716

merged 3 commits into from Oct 18, 2022
+10 −215

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Oct 17, 2022 •
edited

Refactors the internal use of DetermineContentType to consume the version copied to gax-go in v2.6.0.

Removes the original DetermineContentType and supporting internal code/tests.

@noahdietz noahdietz requested review from a team and yoshi-approver as code owners October 17, 2022 21:55
codyoss
codyoss approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update the commit title on merge to reflect changes

@noahdietz noahdietz merged commit 37f90e9 into googleapis:main Oct 18, 2022
@noahdietz noahdietz deleted the gax-determine-ct branch October 18, 2022 18:36
@release-please release-please bot mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver

@quartzmo quartzmo Awaiting requested review from quartzmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noahdietz @quartzmo @codyoss