Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gensupport): add retry invocation headers #1577

Merged
merged 3 commits into from Jun 21, 2022

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Jun 10, 2022

Adds invocation ID and attempt count to x-goog-api-client header
for simple and resumable uploads.

Note that this will also add this information to chunk upload
requests for individual chunks for BQ and other APIs that do uploads
using gensupport as well. Hopefully this isn't an issue; the superfluous
fields should not affect anything.

Similar to googleapis/google-cloud-go#6013

Adds invocation ID and attempt count to x-goog-api-client header
for simple and resumable uploads.

Note that this will also add this information to chunk upload
requests for individual chunks for BQ and other APIs that do uploads
using gensupport as well. Hopefully this isn't an issue.

Similar to googleapis/google-cloud-go#6013
@tritone tritone requested review from a team and yoshi-approver as code owners June 10, 2022 00:44
@tritone tritone requested review from a team and shollyman June 10, 2022 00:45
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small nit.

internal/gensupport/resumable.go Outdated Show resolved Hide resolved
@tritone tritone enabled auto-merge (squash) June 21, 2022 17:56
@tritone tritone merged commit 25e2e24 into googleapis:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants