Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run: cloud_sql_instance field broken by v0.75.0 - no longer works with the API #1519

Closed
billinghamj opened this issue Apr 21, 2022 · 13 comments
Assignees
Labels
api: run Issues related to the Cloud Run API. external This issue is blocked on a bug with the actual product. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@billinghamj
Copy link

Making a new issue from #1497 (comment)

Environment details

  • Programming language: Go
  • OS: macOS 12.3.1 + Ubuntu 20.04.4
  • Language runtime version: 1.18.1
  • Package version: v0.75.0

The problem

In #1513, on the GoogleCloudRunV2CloudSqlInstance struct, the Connections field was renamed to Instances, but the actual API isn't accepting that field name

Steps to reproduce

  1. run (*google.golang.org/api/run/v2.Service).Projects.Locations.Services.Patch with a GoogleCloudRunV2CloudSqlInstance as one of the volumes

Expected

The patch is accepted, a new revision is created and the service runs with the new config

Actual

The API returns an error:

{
	"@type": "type.googleapis.com/google.rpc.BadRequest",
	"fieldViolations": [
		{
			"description": "Invalid JSON payload received. Unknown name \"instances\" at 'service.template.volumes[0].cloud_sql_instance': Cannot find field.",
			"field": "service.template.volumes[0].cloud_sql_instance"
		}
	]
}
@billinghamj billinghamj added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 21, 2022
@product-auto-label product-auto-label bot added the api: run Issues related to the Cloud Run API. label Apr 21, 2022
@codyoss
Copy link
Member

codyoss commented Apr 21, 2022

Hey, thanks for the report. Let me look into this a bit and get back to you.

@codyoss
Copy link
Member

codyoss commented Apr 21, 2022

I have reported this issue internally. I will post back when I hear more. b/229972040

@codyoss codyoss added the external This issue is blocked on a bug with the actual product. label Apr 21, 2022
@billinghamj
Copy link
Author

billinghamj commented Apr 26, 2022

@codyoss any movement on this? Quite a long time for the API to be broken - could the priority be bumped maybe?

@codyoss
Copy link
Member

codyoss commented Apr 26, 2022

Does the previous version of the API work since it still seems to want the previous field? The bug is still be worked on.

@billinghamj
Copy link
Author

The previous version of this library works, but the API itself hasn't changed - we're holding off from updating for now, but we do want to get up-to-date as soon as we can

@codyoss
Copy link
Member

codyoss commented Apr 26, 2022

Sounds good, I will update this issue if I learn more.

@billinghamj
Copy link
Author

Looks like the issue remains on v0.76.0, where the run API is churning significantly. If the v2 API wasn't meant to be released, maybe it shouldn't be publicly documented or included in these clients(?)

@codyoss
Copy link
Member

codyoss commented Apr 27, 2022

@billinghamj The v2 API is considered in preview right now according to its public docs: https://cloud.google.com/run/docs/reference/rest

@billinghamj
Copy link
Author

Unfortunately it didn't say that a couple of weeks ago :\

@billinghamj
Copy link
Author

billinghamj commented Apr 28, 2022

It appears that the API is now inconsistently rejecting both instances and connections, meaning there is now no version of this library which works. We're no longer able to deploy at all, merge PRs, test our work, etc

It also seems like the inconsistency might relate to our GCP projects - but it's hard to be sure

@DuffleOne
Copy link

@billinghamj and I have opened a GCP support case for this (Case #29751838)

@billinghamj
Copy link
Author

Same problem is now arising with the containerConcurrency field. Looks like it has been renamed, but the updated client version hasn't been released/tagged yet

In the meantime, this works:

replace google.golang.org/api v0.79.0 => github.com/googleapis/google-api-go-client v0.0.0-20220509151825-2b05dc140c5f

require google.golang.org/api v0.79.0

@codyoss
Copy link
Member

codyoss commented Jun 29, 2022

This issue has since been resolved and the backend issue fixed. Closing.

@codyoss codyoss closed this as completed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: run Issues related to the Cloud Run API. external This issue is blocked on a bug with the actual product. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants