feat(gensupport): per-chunk deadline configs #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to configure the per-chunk deadline for retries that's used during resumable uploads. Needs to be exposed via the manual layer for storage. Fixes googleapis#685
This was referenced Feb 1, 2022
frankyn
requested changes
Feb 1, 2022
| // will be returned to the caller. | ||
| // This is only applicable for files which are large enough to require | ||
| // a multi-chunk resumable upload. | ||
| // The default value is 32s. |
There was a problem hiding this comment.
Has 32s at per chunk been the default for a while now?
There was a problem hiding this comment.
Yep, and there was a default of 16s prior to that apparently.
frankyn
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(gensupport): per-chunk deadline configs
Allow users to configure the per-chunk deadline for retries
that's used during resumable uploads.
Needs to be exposed via the manual layer for storage.
Fixes #685