Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(internal/gensupport): add 408 to default retry #1397

Merged
merged 3 commits into from Jan 18, 2022
Merged

feat(internal/gensupport): add 408 to default retry #1397

merged 3 commits into from Jan 18, 2022

Conversation

BrennaEpp
Copy link
Contributor

No description provided.

@BrennaEpp BrennaEpp requested review from yoshi-approver and a team as code owners January 13, 2022 04:23
codyoss
codyoss approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tritone
Copy link
Contributor

tritone commented Jan 14, 2022

LGTM but adding @shollyman as a reviewer to confirm that this would be acceptable to BQ as well.

shollyman
shollyman approved these changes Jan 15, 2022
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with 408 retry that I can think of.

@codyoss codyoss enabled auto-merge (squash) January 18, 2022 16:34
@codyoss codyoss merged commit 576ebbf into googleapis:main Jan 18, 2022
@release-please release-please bot mentioned this pull request Jan 18, 2022
Merged
@release-please release-please bot mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@tritone tritone tritone approved these changes

@codyoss codyoss codyoss approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BrennaEpp @tritone @shollyman @codyoss