Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transport): remove google-c2p dependence to DirectPath #1361

Merged
merged 2 commits into from Dec 21, 2021

Conversation

mohanli-ml
Copy link
Contributor

Remove google-c2p dependency to the entire google-api-go-client. Instead, services using DirectPath should add the dependency by itself, like googleapis/google-cloud-go#5090.

Issue: #1283


import (
// Install google-c2p resolver, which is required for direct path.
_ "google.golang.org/grpc/xds/googledirectpath"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please run go mod tidy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry I forgot this. Just resubmitted. Thanks!

@codyoss codyoss enabled auto-merge (squash) December 21, 2021 20:34
@codyoss codyoss merged commit e84950f into googleapis:main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants