feat(googleapi): support setting arbitrary query parameters #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
tbpg
reviewed
Jul 20, 2021
There was a problem hiding this comment.
Found GoogleCloudPlatform/golang-samples#1015 for some history.
|
Yeah I am not sure if there is any other API besides healthcare that needs this but it is at least useful/needed for that API I believe. With how CallOptions currently work this is no way for a user to provide a key with multiple values. |
broady
reviewed
Jul 27, 2021
broady
approved these changes
Aug 4, 2021
codyoss
added
the
automerge
codyoss
added
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #550