Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit from earlier today doesn't appear to be BW compat. Is that by design? #700

Closed
mornindew opened this issue Oct 15, 2021 · 2 comments
Closed

Commit from earlier today doesn't appear to be BW compat. Is that by design? #700

mornindew opened this issue Oct 15, 2021 · 2 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@mornindew
Copy link

mornindew commented Oct 15, 2021 •
edited

I am attempting to update my go packages with go get -u but I am getting the error:

cloud.google.com/go/storage
# cloud.google.com/go/storage
../../../../../../cloud.google.com/go/storage/storage.go:1447:53: o.GetCustomerEncryption().GetKeySha256 undefined (type *"google.golang.org/genproto/googleapis/storage/v2".Object_CustomerEncryption has no field or method GetKeySha256)
../../../../../../cloud.google.com/go/storage/writer.go:439:10: q.GetCommittedSize undefined (type *"google.golang.org/genproto/googleapis/storage/v2".QueryWriteStatusResponse has no field or method GetCommittedSize)

I looked into it and it appears that code was introduced today that removed both the GetKeySha256 and GetCommittedSize methods from the storage.pb.go file. Is that by design or is that an oversight?

https://github.com/googleapis/go-genproto/blob/master/googleapis/storage/v2/storage.pb.go

Thanks,
Craig
@mornindew mornindew added priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue. labels Oct 15, 2021
@codyoss
Copy link
Member

codyoss commented Oct 15, 2021

Hey, this was an intentional breaking change to a currently internal api. This should not be an issue once googleapis/google-cloud-go#4987 is merged.

Also, in general I would avoid using go get -u as it will try to update all dependencies in a project, which may result in incompatibilities like this. Instead I would update individual direct dependencies only. The storage module make use of go modules to track the versions of individual dependencies that should be used: https://github.com/googleapis/google-cloud-go/blob/faa764c9470cb03d04504448d97b0beba95541e2/storage/go.mod#L13.

For now I would downgrade genproto to the version declared in the most recent release of the storage client. Hope that helps!

@codyoss codyoss closed this as completed Oct 15, 2021
@codyoss codyoss mentioned this issue Oct 18, 2021
Closed
@mornindew
Copy link
Author

Thanks a lot. That was exactly what I needed.

rsbh added a commit to raystack/frontier that referenced this issue Nov 17, 2021
@rsbh
fix: googleapis/go-genproto#700
76e3d44
krtkvrm pushed a commit to raystack/frontier that referenced this issue Dec 10, 2021
@rsbh
feat: schema generator (#31)
0f57be2 
* feat: add build_schema function

* feat: add function to build policy definiton

* chore: add namespace to roles

* chore: add subtype to roles

* chore: add actions table

* chore: add namespaces table

* chore: add support for multiple role types

* feat: add build_schema function

* feat: add function to build policy definiton

* chore: add namespace to roles

* chore: add subtype to roles

* chore: add actions table

* chore: add namespaces table

* chore: add support for multiple role types

* fix: googleapis/go-genproto#700

* refactor: move schema models to model package

* chore: add policies table

* refactor: change schema generator Policy to model.Policy

* refactor: change struct keys to lowercase

* chore: add namespace_id to roles and actions
remove slug from actions and namepaces

* refactor: remove slug from namespace and actions
add namespaceId to roles and actions

* chore: add check for action namespace in schema generation

* chore: namespace_id to actions and roles struct

* fix: create roles api db error

* chore: add list policies api

* chore: register policy service

* chore: add create policy api

* chore: add get policy api

* chore: add update policy api

* chore: add schema generator to create and update policy

* chore: add spicedb config and setup in docker-compose

* chore: add authz package to connect to spicedb

* chore: add authz AddPolicy Method

* refactor: fix lint issues

* chore: add hook to push schema to spicedb on Create and Update Policy

* chore: add namespace field to roles response

* feat: add namespace apis

* feat: add actions crud apis

* feat: add polices crud apis

* fix: go import lint issues

* chore: update proto path for shield apis

* chore: add shield apis proto generated files

* fix: lint issues

* fix: policy tests issue

* fix: schema generator tests issue

* fix: sort definitions to fix Schema generator tests issue

* fix: sort roles and actions to fix tests

* chore: update shield proto path

* chore: cleanup unused code and logs

* chore: pass context to AddPolicy

* chore: fix typo and update polices query to take argument

* chore(policy): Add Update method for action and namespace
yoshi-automation added a commit that referenced this issue Feb 15, 2022
@yoshi-automation
chore(all): auto-regenerate .pb.go files
5e9addb 
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#5659

Changes:

chore: regenerate API index

  Source-Link: googleapis/googleapis@82cc6da

feat(osconfig/agentendpoint): Add fields to RegisterAgentRequest:   - supported_capabilities   - os_long_name   - os_short_name   - os_version   - os_architecture feat: Add field to PatchConfig message:   - mig_instances_allowed fix: Add NONE Interpreter enum value that should be used over INTERPRETER_UNSPECIFIED in ExecStepConfig message
  PiperOrigin-RevId: 428781221
  Source-Link: googleapis/googleapis@f158f82

chore: Update C# generator version
  PiperOrigin-RevId: 428710197
  Source-Link: googleapis/googleapis@bbfb179

chore: regenerate API index

  Source-Link: googleapis/googleapis@3063338

feat(servicemanagement)!: Remove EnableService and DisableService RPC methods and related protos from service management API BREAKING CHANGE:
  PiperOrigin-RevId: 428693468
  Source-Link: googleapis/googleapis@42a19d6

fix(security/privateca): Add google-cloud-location as a dependency for the privateca client
  PiperOrigin-RevId: 428624147
  Source-Link: googleapis/googleapis@d19f69b

fix(ruby): Update kms-v1 dependency to 0.11 to ensure support for managing EKM connections
  PiperOrigin-RevId: 428591419
  Source-Link: googleapis/googleapis@23d18b4

fix(ruby): Update grafeas-v1 dependency for google-cloud-container_analysis-v1
  PiperOrigin-RevId: 428585171
  Source-Link: googleapis/googleapis@2ab0f06

chore(deps): upgrade gapic-generator-java to 2.6.1 and update gax-java to 2.12.2
  PiperOrigin-RevId: 428569213
  Source-Link: googleapis/googleapis@3ec9414

chore(python): Prepare google/cloud/certificatemanager v1 BUILD.bazel for release
  PiperOrigin-RevId: 428507726
  Source-Link: googleapis/googleapis@82528cf

chore(video/livestream): Configure Ruby generator for Video Live Stream clients
  PiperOrigin-RevId: 428111509
  Source-Link: googleapis/googleapis@7c7a99a

chore(servicemanagement): cleanup unused imports in google/api/servicemanagement/v1
  PiperOrigin-RevId: 428077790
  Source-Link: googleapis/googleapis@4807247

chore(dataplex): Configure Ruby generator for Dataplex clients
  PiperOrigin-RevId: 428067759
  Source-Link: googleapis/googleapis@1798403

chore(ruby): Configure Ruby generator for Video Stitcher clients
  PiperOrigin-RevId: 428067710
  Source-Link: googleapis/googleapis@8a718b2

chore: disable Python snippetgen for BigQuery
  PiperOrigin-RevId: 428049027
  Source-Link: googleapis/googleapis@eec8a47

fix(compute): fix breaking changes in Compute API (#701)

  Source-Link: googleapis/googleapis@272c110

fix(pubsub)!: removing misspelled field, add correctly spelled field
  PiperOrigin-RevId: 428023165
  Source-Link: googleapis/googleapis@63d374d

fix(osconfig/agentendpoint): Fix description of an interpreter field, validate if the field is not unspecified
  PiperOrigin-RevId: 427987153
  Source-Link: googleapis/googleapis@a1b62c1

chore: regenerate API index

  Source-Link: googleapis/googleapis@7a30891

fix(osconfig/agentendpoint): update third_party protos to the most actual version: - Add item that is affected by vulnerability - Add GetOsPolicyAssignmentReport and analogous List rpc method - Add Inventory to InstanceFilter - Add existing os_policy_assignment_reports.proto fixing the build - Mark methods as deprecated
  PiperOrigin-RevId: 427981818
  Source-Link: googleapis/googleapis@0b2c906

feat(compute): update compute API to revision 20220112 (#700)

  Source-Link: googleapis/googleapis@249e9a1
@yoshi-automation yoshi-automation mentioned this issue Feb 15, 2022
Merged
codyoss pushed a commit that referenced this issue Feb 15, 2022
@yoshi-automation
chore(all): auto-regenerate .pb.go files (#760)
e57b466 
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#5659

Changes:

chore: regenerate API index

  Source-Link: googleapis/googleapis@82cc6da

feat(osconfig/agentendpoint): Add fields to RegisterAgentRequest:   - supported_capabilities   - os_long_name   - os_short_name   - os_version   - os_architecture feat: Add field to PatchConfig message:   - mig_instances_allowed fix: Add NONE Interpreter enum value that should be used over INTERPRETER_UNSPECIFIED in ExecStepConfig message
  PiperOrigin-RevId: 428781221
  Source-Link: googleapis/googleapis@f158f82

chore: Update C# generator version
  PiperOrigin-RevId: 428710197
  Source-Link: googleapis/googleapis@bbfb179

chore: regenerate API index

  Source-Link: googleapis/googleapis@3063338

feat(servicemanagement)!: Remove EnableService and DisableService RPC methods and related protos from service management API BREAKING CHANGE:
  PiperOrigin-RevId: 428693468
  Source-Link: googleapis/googleapis@42a19d6

fix(security/privateca): Add google-cloud-location as a dependency for the privateca client
  PiperOrigin-RevId: 428624147
  Source-Link: googleapis/googleapis@d19f69b

fix(ruby): Update kms-v1 dependency to 0.11 to ensure support for managing EKM connections
  PiperOrigin-RevId: 428591419
  Source-Link: googleapis/googleapis@23d18b4

fix(ruby): Update grafeas-v1 dependency for google-cloud-container_analysis-v1
  PiperOrigin-RevId: 428585171
  Source-Link: googleapis/googleapis@2ab0f06

chore(deps): upgrade gapic-generator-java to 2.6.1 and update gax-java to 2.12.2
  PiperOrigin-RevId: 428569213
  Source-Link: googleapis/googleapis@3ec9414

chore(python): Prepare google/cloud/certificatemanager v1 BUILD.bazel for release
  PiperOrigin-RevId: 428507726
  Source-Link: googleapis/googleapis@82528cf

chore(video/livestream): Configure Ruby generator for Video Live Stream clients
  PiperOrigin-RevId: 428111509
  Source-Link: googleapis/googleapis@7c7a99a

chore(servicemanagement): cleanup unused imports in google/api/servicemanagement/v1
  PiperOrigin-RevId: 428077790
  Source-Link: googleapis/googleapis@4807247

chore(dataplex): Configure Ruby generator for Dataplex clients
  PiperOrigin-RevId: 428067759
  Source-Link: googleapis/googleapis@1798403

chore(ruby): Configure Ruby generator for Video Stitcher clients
  PiperOrigin-RevId: 428067710
  Source-Link: googleapis/googleapis@8a718b2

chore: disable Python snippetgen for BigQuery
  PiperOrigin-RevId: 428049027
  Source-Link: googleapis/googleapis@eec8a47

fix(compute): fix breaking changes in Compute API (#701)

  Source-Link: googleapis/googleapis@272c110

fix(pubsub)!: removing misspelled field, add correctly spelled field
  PiperOrigin-RevId: 428023165
  Source-Link: googleapis/googleapis@63d374d

fix(osconfig/agentendpoint): Fix description of an interpreter field, validate if the field is not unspecified
  PiperOrigin-RevId: 427987153
  Source-Link: googleapis/googleapis@a1b62c1

chore: regenerate API index

  Source-Link: googleapis/googleapis@7a30891

fix(osconfig/agentendpoint): update third_party protos to the most actual version: - Add item that is affected by vulnerability - Add GetOsPolicyAssignmentReport and analogous List rpc method - Add Inventory to InstanceFilter - Add existing os_policy_assignment_reports.proto fixing the build - Mark methods as deprecated
  PiperOrigin-RevId: 427981818
  Source-Link: googleapis/googleapis@0b2c906

feat(compute): update compute API to revision 20220112 (#700)

  Source-Link: googleapis/googleapis@249e9a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mornindew @codyoss