Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bazel attribute that generates a GAPIC using snake_case identifiers #961

Open
aohren opened this issue Aug 26, 2021 · 3 comments
Open
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@aohren
Copy link

aohren commented Aug 26, 2021

Some consumers of Node.js GAPICs prefer snake_case rather than camelCase in the developer surface (e.g., https://github.com/Opteo/google-ads-node). To support this, they're employing a custom fork of gax-nodejs to modify the casing. Supporting this directly as a GAPIC config option on Bazel build rules will alleviate them from needing to hack gax-nodejs.

@aohren aohren added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Aug 26, 2021
@summer-ji-eng
Copy link
Collaborator

@aohren want to follow up do you still need this feature. Let's sync.

@aohren
Copy link
Author

aohren commented Feb 4, 2022

Yea this is still something we'd like to have. I set up some time for us to chat about it.

@summer-ji-eng
Copy link
Collaborator

Customer fork the gax-nodejs to customized to keep the snake_case.(see change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants